Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ONBUILD variant deprecation, remove dead Ruby link #7204

Closed
wants to merge 2 commits into from

Conversation

javabrett
Copy link
Contributor

Removes a link to the Ruby ONBUILD Dockerfile variant, which was burniated in docker-library/ruby@b9e495c . Most ONBUILD variants of base library images are deprecated/removed per docker-library/official-images#2076 . Maybe the doc on the use of BUILD could have more warnings on its limitations, so a second commit here with a note on the deprecations in base images.

@GordonTheTurtle
Copy link

GordonTheTurtle commented Aug 10, 2018

Deploy preview for modest-edison-79d82e ready!

Built with commit ad1f58d

https://deploy-preview-7204--modest-edison-79d82e.netlify.com

@javabrett
Copy link
Contributor Author

Review requested - the current description and links to ONBUILD are misleading.

Signed-off-by: Brett Randall <javabrett@gmail.com>
Signed-off-by: Brett Randall <javabrett@gmail.com>
@ghost
Copy link

ghost commented Jan 2, 2019

Closing this ticket due to its age, and the impending refactor. If you think this is in error, feel free to reopen. Thanks!

@ghost ghost closed this Jan 2, 2019
@javabrett
Copy link
Contributor Author

@L-Hudson I don't seem to have access to re-open this. Rebased commits.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Relates to Dockerfiles or docker build command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants