This repository has been archived by the owner on Nov 23, 2019. It is now read-only.
Throw client.Do(req) error in postHijacked #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometime when client issues an http request throw clientconn.Do(req), server can send an error through hijacked http connection and close this connection afterwards. We need to throw this error(httputil.ErrPersistEOF) out, to let client know the connection is closed, so client can choose to abort after reading detailed error message from hijacked connection. Also client can ignore other kinds of errors. Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
|
LGTM 🐙 |
| @@ -68,11 +68,11 @@ func (cli *Client) postHijacked(ctx context.Context, path string, query url.Valu | |||
| defer clientconn.Close() | |||
|
|
|||
| // Server hijacks the connection, error 'connection closed' expected | |||
| clientconn.Do(req) | |||
| _, err = clientconn.Do(req) | |||
There was a problem hiding this comment.
should we return here before calling Hijack() if err != nil?
There was a problem hiding this comment.
ah that's a good point I think.
There was a problem hiding this comment.
No, hijack is still necessary. The case is, server meets an error, it sends error message via Hijacked connection then close it. Client gets an ErrPersistError, but it can still read error message from low level tcp connection.
So we need to do Hijack() even though error happened, only need to throw it out and let client choose how to handle the error
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related docker PR: moby/moby#21092
Sometime when client issues an http request via clientconn.Do(req),
server can send an error through hijacked http connection and close this
connection afterwards. We need to throw this error(httputil.ErrPersistEOF)
out, to let client know the connection is closed, so client can choose
to abort after reading detailed error message from hijacked connection.
Also client can ignore other kinds of errors, so it won't bring any problem.
And it will make more sense to not swallow the error.
Signed-off-by: Zhang Wei zhangwei555@huawei.com