Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest versions of everything #317

Merged
merged 9 commits into from
Nov 25, 2022

Conversation

mikesir87
Copy link
Member

Lots of updates to bring the app up to current versions, info, etc. Those items include:

  • Updated the app from node:12-alpine to node:18-alpine (latest LTS version)
  • Upgrade all app dependencies to their latest versions
  • Remove need to install python, make, and other build tools as they are no longer needed due to other upgrades
  • Upgrade mysql to 8.0, which facilitated the switch from the mysql to mysql2 NPM package (to support latest auth protocols MySQL uses)
  • Upgrade all dashboard screenshots to current version of Docker Desktop
  • Swap all Docker Compose examples to use the current spec (getting rid of the version key)
  • Update all links going to Compose v3 to current Compose spec docs
  • Upgrade all docker-compose commands to docker compose
  • Update various build outputs to match that seen by BuildKit as it's the default builder now
  • Update main docs Dockerfile to force the test stage to run (since BuildKit is smart enough to skip the stage if it isn't specifically used)

Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
@StefanScherer
Copy link
Member

Thank you, this is a huge improvement! 😍
Looking through it right now. Could we also change the main README.md file to use docker compose up without the dash? :-)

Signed-off-by: Michael Irwin <mikesir87@gmail.com>
@mikesir87
Copy link
Member Author

Ah! Good catch @StefanScherer! Just updated the README.md and found one other spot still referencing docker-compose up.

Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mikesir87 mikesir87 merged commit d7d4b09 into master Nov 25, 2022
@mikesir87 mikesir87 deleted the update-to-latest-versions-of-everything branch November 25, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants