-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest versions of everything #317
Conversation
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Thank you, this is a huge improvement! 😍 |
Signed-off-by: Michael Irwin <mikesir87@gmail.com>
Ah! Good catch @StefanScherer! Just updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Lots of updates to bring the app up to current versions, info, etc. Those items include:
node:12-alpine
tonode:18-alpine
(latest LTS version)8.0
, which facilitated the switch from themysql
tomysql2
NPM package (to support latest auth protocols MySQL uses)version
key)docker-compose
commands todocker compose
Dockerfile
to force thetest
stage to run (since BuildKit is smart enough to skip the stage if it isn't specifically used)