ParsePortSpec: handle IPv6 addresses #17
Conversation
split out of moby/moby#20315 in order to fix moby/moby#11518 Signed-off-by: Michael Stapelberg <stapelberg@google.com>
|
Can this be merged? This is kind of essential as you can't bind containers to IPv6-Addresses at the moment. @LK4D4 you seem the most active contributor from the Docker team. Can you review this? |
| parts, err = PartParser(portSpecTemplate, rawPort) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
I think there is an easier way to handle this. PartParser() is an unfortunate abstraction. It's a generic way of escaping : separated strings with no way to escape : within the parts, and which is only used in a single place.
This code effectively introduces a new PartParser() that supports escaping colons using square brackets, but doesn't take advantage of the built-in functions in net and net/url`.
I think we should fix this by deprecating PartParser(), and replacing it with a new function that just parses the port spec into the appropriate parts using the available built-in functions.
|
We should add a test case as well, once we work out the implementation. |
|
@dnephin I don’t have strong opinions on how the code should look like. Would you want to add a test and refactor it so that it corresponds to your ideals? :) |
|
I opened #19 with those changes |
split out of moby/moby#20315
in order to fix moby/moby#11518
Signed-off-by: Michael Stapelberg stapelberg@google.com