Update system cert pool update for Go 1.8 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addresses moby/moby#30450 |
|
ping @aaronlehmann @cyli PTAL |
aaronlehmann
reviewed
Feb 3, 2017
tlsconfig/certpool_go17.go
Outdated
| @@ -14,7 +14,7 @@ import ( | |||
| func SystemCertPool() (*x509.CertPool, error) { | |||
| certpool, err := x509.SystemCertPool() | |||
| if err != nil && runtime.GOOS == "windows" { | |||
| logrus.Warnf("Unable to use system certificate pool: %v", err) | |||
| logrus.Info("Unable to use system certificate pool: %v", err) | |||
Go 1.8 adds support for windows certificate pool, ensure that the system cert pool is just called directly. Any error in windows should propagate to the caller. Change log message for windows error from warn to info since it is not actionable in go 1.7. Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
dmcgowan
force-pushed
the
update-tlsconfig-go-18
branch
from
3748e17
to
3723764
Compare
|
Updated, Stephen thinks this should remain at |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.8 adds support for windows certificate pool, ensure
that the system cert pool is just called directly. Any
error in windows should propagate to the caller.
Change log message for windows error from warn to info
since it is not actionable in go 1.7.