Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.14.12 #54

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Conversation

tao12345666333
Copy link
Contributor

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

@Jacalz
Copy link

Jacalz commented Apr 7, 2020

Any chance of getting this merged or/and updated to 1.14.1?
Would be wonderful to get some faster defer statements going :)

@tao12345666333
Copy link
Contributor Author

ping @thaJeztah PTAL, thanks!

@thaJeztah
Copy link
Member

I'd like to hold off for a bit; we're not yet updating our toolchain to Go 1.14, because there's some regressions / incompatibilities with Go 1.14 related tot the preemptive changes made in that release.

@Jacalz
Copy link

Jacalz commented Aug 13, 2020

I would say that it’s time to get this landed now. With 1.15 out of the door, 1.13.x won’t receive updates any more which isn’t ideal from a security standpoint.

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 changed the title Update to Go 1.14.0 Update to Go 1.14.9 Sep 13, 2020
@tao12345666333
Copy link
Contributor Author

rebased.

@Jacalz
Copy link

Jacalz commented Nov 6, 2020

Sorry, but could we please get this merged soon? It is getting very necessary to get 1.14.10 landed due to the big timezone issue, golang/go/issues/42138 among with 1.13.x not getting any security fixes. This has sat open for almost nine months.

@tao12345666333
Copy link
Contributor Author

Sorry, but could we please get this merged soon? It is getting very necessary to get 1.14.10 landed due to the big timezone issue, golang/go/issues/42138 among with 1.13.x not getting any security fixes. This has sat open for almost nine months.

ping @thaJeztah
Thanks!

Copy link

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An update to 1.14.10 would be useful as it contains two security fixes.

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@carleeto
Copy link

carleeto commented Dec 2, 2020

Hi, we're at v1.14.12, which is the latest 1.14 version as of today. I would suggest merging now, since all downstream projects that depend on the golang-cross image will gain the ability to automatically support vendored dependencies in Go modules, which is a change that was introduced in Go 1.14

@tao12345666333 tao12345666333 changed the title Update to Go 1.14.9 Update to Go 1.14.12 Dec 3, 2020
@jlk
Copy link

jlk commented Apr 23, 2021

Not sure how this is being used by Docker - if this is merged, dockercore/golang-cross:1.13.15 would still be on docker hub for use, but those of us who wanted newer could have that as well, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants