Removed dockerinit reference #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tainer() Signed-off-by: Sambuddha Basu <sambuddhabasu1@gmail.com>
|
ping @LK4D4 @jfrazelle |
|
Looks ok) |
|
Can this PR be merged or are there any changes required? |
|
LGTM |
sebn
added a commit
to sebn/elm-live
that referenced
this pull request
Dec 9, 2017
Without polling, file changes from a mounted volume may not be detected. See similar [nodemon caveat](https://github.com/remy/nodemon#application-isnt-restarting). Although `/.dockerenv` content [is not being used anymore](moby/libnetwork#815), it still seems to be a reilable way to detect whether we are running inside a Docker container.
sebn
added a commit
to sebn/elm-live
that referenced
this pull request
Dec 9, 2017
Without polling, file changes from a mounted volume may not be detected. See similar [nodemon caveat][1] Although `/.dockerenv` content [is not being used anymore][2], it still seems to be a reliable way to detect whether we are running inside a Docker container. [1]: https://github.com/remy/nodemon#application-isnt-restarting [2]: moby/libnetwork#815
sebn
added a commit
to sebn/elm-live
that referenced
this pull request
Dec 9, 2017
Without polling, file changes from a mounted volume may not be detected. See similar [nodemon caveat][1]. Although `/.dockerenv` content [is not being used anymore][2], it still seems to be a reliable way to detect whether we are running inside a Docker container. [1]: https://github.com/remy/nodemon#application-isnt-restarting [2]: moby/libnetwork#815
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced reference to dockerinit by dockerenv for func isRunningInContainer()
This PR refers to moby/moby#18355