remove dockerinit

[jessfraz]

the only thing relying on it is https://github.com/docker/libnetwork/blob/9fb7ba8fa01f0ddce99713799e760223c842fb4b/drivers/bridge/setup_bridgenetfiltering.go#L159

cc @rhatdan I think you wanted this as well

cc @tianon

[jessfraz]

ping @mrjana @mavenugo

[jessfraz]

ping @LK4D4 just to make sure that was the only thing hanging for removal

[jessfraz]

gettting this for #17989 will help us not need libseccomp.a when compiling the binaries because dockerinit is static, it is trying to find it now

[rhatdan]

I am all for this, the only problem I have is a side effect. Currently one of my patches uses the location of dockerinit to figure out where alternate docker binaries are stored. /usr/libexec/docker on Red Hat based OS. /usr/lib/docker on others.

If we had a standard directory for helper executables to be installed...

[jessfraz]

woohooooo we want the same thing <3

On Wed, Dec 2, 2015 at 7:05 AM, Daniel J Walsh notifications@github.com
wrote:

I am all for this, the only problem I have is a side effect. Currently one
of my patches uses the location of dockerinit to figure out where alternate
docker binaries are stored. /usr/libexec/docker on Red Hat based OS.
/usr/lib/docker on others.

If we had a standard directory for helper executables to be installed...

—
Reply to this email directly or view it on GitHub
#18355 (comment).

[LK4D4]

@jfrazelle Yeah, I don't see other places. I never build dockerinit and /.dockerinit in container is just empty file.

[zelahi]

I would like to take on this issue, but please correct me if I am misinterpreting it

The following file needs to be removed:
https://github.com/docker/docker/blob/master/dockerinit/dockerinit.go

and the following file needs to be updated to not reference .dockerinit:
https://github.com/docker/libnetwork/blob/9fb7ba8fa01f0ddce99713799e760223c842fb4b/drivers/bridge/setup_bridgenetfiltering.go#L159

[jessfraz]

it touches a lot of places a lot of things will need to be changed in
engine, but awesome you are willing to take it on

On Thu, Dec 3, 2015 at 3:11 PM, Zuhayr Elahi notifications@github.com
wrote:

I would like to take on this issue, but please correct me if I am
misinterpreting it

The following file needs to be removed:
https://github.com/docker/docker/blob/master/dockerinit/dockerinit.go

and the following file needs to be updated to not reference .dockerinit:

https://github.com/docker/libnetwork/blob/9fb7ba8fa01f0ddce99713799e760223c842fb4b/drivers/bridge/setup_bridgenetfiltering.go#L159

—
Reply to this email directly or view it on GitHub
#18355 (comment).

[sambuddhabasu]

Is anyone working on this issue currently? If no, I would like to work on it.

[thaJeztah]

@zelahi are you working on this?

[zelahi]

@sammyshj go ahead and take this one =)

[sambuddhabasu]

The dockerinit file is mentioned in many files. Should all these references be handled and then the dockerinit file be removed?

[LK4D4]

@sammyshj yeah, I think so

[sambuddhabasu]

The dockerinit file is also referenced in the file https://github.com/docker/docker/blob/master/daemon/container_operations_unix.go#L234
By removing the dockerinit file, all of these files also has to be modified. Can I know what the InitPath has to be modified into?

[LK4D4]

@sammyshj InitPath shouldn't be needed after removing.

[jessfraz]

Ya the files I specified weren't obviously the only ones like I've said
before it's a deep rabbit hole in terms of things it touches and InitPath
is just another thing that removed by removing dockerinit ;) have fun

On Friday, December 11, 2015, Alexander Morozov notifications@github.com
wrote:

@sammyshj https://github.com/sammyshj InitPath shouldn't be needed
after removing.

—
Reply to this email directly or view it on GitHub
#18355 (comment).

[jessfraz]

The original file path was merely the only one not in docker/docker so you
might want to start w the PR to libnetwork ;)
THEN you can vendor that change into docker
THEN you can worry about all the other stuff dockerinit touches

On Friday, December 11, 2015, Jessie Frazelle jess@docker.com wrote:

Ya the files I specified weren't obviously the only ones like I've said
before it's a deep rabbit hole in terms of things it touches and InitPath
is just another thing that removed by removing dockerinit ;) have fun

On Friday, December 11, 2015, Alexander Morozov <notifications@github.com
javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

@sammyshj https://github.com/sammyshj InitPath shouldn't be needed
after removing.

—
Reply to this email directly or view it on GitHub
#18355 (comment).

[sambuddhabasu]

Thanks for making things clear @LK4D4 and @jfrazelle . Working on it right now!

[gianarb]

Maybe this issue should be closed? :)
The pull is merged 👍

[LK4D4]

@gianarb I think only in libnetwork. There is a long road ahead.

[mpl]

@jfrazelle Hi. I I have some code that used to rely on the presence of /.dockerinit to detect whether it is run in a docker container (If not, log.Fatal with a warning so the users know they're not supposed to run that out of docker). What is the correct/suggested way to perform that sort of detection nowadays please?

[LK4D4]

@mpl there is .dockerenv file, have no idea what it does though :)

[thaJeztah]

@LK4D4 may actually be for that; https://github.com/docker/docker/blob/3d13fddd2bc4d679f0eaa68b0be877e5a816ad53/vendor/src/github.com/docker/libnetwork/drivers/bridge/setup_bridgenetfiltering.go#L159-L162

[mika]

@tianon so when you've code which previously checked for presence of /.dockerinit what's the proper way to handle this with recent versions of docker nowadays? Should /proc/1/cgroup be parsed (as done e.g. by puppet's facter tool) or is there any better/easier way? Thanks for any input :)

[LK4D4]

@mika there is /.dockerenv :)

[mika]

@LK4D4 which tianon recommended to not rely on: " I would not recommend
relying on its existence either (IIRC, that code you've linked to is the
only reason it still exists)" (quoting from #18355 (comment))