manager: remove hack for unix-socket listener #1541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 53.73% (diff: 100%)@@ master #1541 diff @@
==========================================
Files 82 82
Lines 13430 13432 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 7228 7218 -10
- Misses 5219 5227 +8
- Partials 983 987 +4
|
| @@ -549,7 +536,7 @@ func (m *Manager) serveListener(ctx context.Context, errServe chan error, proto | |||
| // we need to disallow double closes because UnixListener.Close | |||
| // can delete unix-socket file of newer listener. grpc calls | |||
| // Close twice indeed: in Serve and in Stop. | |||
It was fixed in grpc Signed-off-by: Alexander Morozov <lk4d4math@gmail.com>
|
Good byte, dirty hacks. |
stevvooe
approved these changes
Sep 15, 2016
|
I am not sure if this idea will be popular, but could we instead wrap the listener with something that panics if I'm worried that this might regress in grpc in the future, and it will be hard to notice. Or we could keep the |
|
@aaronlehmann I've opened golang/go#17131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was fixed in grpc