-
Notifications
You must be signed in to change notification settings - Fork 221
Feedback from Mumbai workshop #5
base: master
Are you sure you want to change the base?
Conversation
1. Errata in app.js file path 2. Adding verification step for succeesful completion of commands
1. Errata in app.js file path 2. Adding verification step for succeesful completion of commands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of comments and items of feedback.
@@ -9,7 +9,7 @@ Pretty simple, right? Let's make the change. | |||
|
|||
## Updating our Source Code | |||
|
|||
1. In the `~/app/src/static/js/app.js` file, update line 56 to use the new empty text. ([Editing files in PWD tips here](/pwd-tips#editing-files)) | |||
1. In the `~/app/src/static/app.js` file, update line 56 to use the new empty text. ([Editing files in PWD tips here](/pwd-tips#editing-files)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source is in app/src/static/js
, but is a fairly recent change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know when the change was made? Bcos the folks faced this on Saturday?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd. It was made Friday my time, so let me run through it real quick and see if it's still an issue 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -67,7 +73,7 @@ So, let's do it! | |||
|
|||
When you're done watching the logs, exit out by hitting `Ctrl`+`C`. | |||
|
|||
1. Now, let's make a change to the app. In the `src/static/js/app.js` file, let's change the "Add Item" button to simply say | |||
1. Now, let's make a change to the app. In the `src/static/app.js` file, let's change the "Add Item" button to simply say |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The source is in src/static/js/app.js
here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Authored-By: Michael Irwin <mikesir87@gmail.com>
Co-Authored-By: Michael Irwin <mikesir87@gmail.com>
Co-Authored-By: Michael Irwin <mikesir87@gmail.com>
Co-Authored-By: Michael Irwin <mikesir87@gmail.com>
Co-Authored-By: Michael Irwin <mikesir87@gmail.com>
No description provided.