-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: biometry check #212
fix: biometry check #212
Conversation
field.path?.includes('$.type[*]') && | ||
field.filter?.const === BIOMETRIC_CREDENTIAL_TYPE, | ||
field =>{ | ||
const biometricAttributeMatch = new RegExp(/^\$.credentialSubject.biometric/); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think id
, data
, and created
are required. Shouldn't we ensure those 3 properties will be present?
…rk/react-native-sdk into feat/biometric-binding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there any tests around this that need to change?
No test here yet since the plugin is still just a placeholder implementation for now. |
Proposed changes
Fixing biometric check criteria