Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance exec internals #930

Closed
achekulaev opened this issue Jan 4, 2019 · 3 comments
Closed

Enhance exec internals #930

achekulaev opened this issue Jan 4, 2019 · 3 comments
Assignees
@achekulaev
Labels
🏷enhancement size/small Effort in T-Shirt scale
Projects
Docksal 1.12.0

Comments

@achekulaev
Copy link
Member

Only run bash for cli container. For others use docker exec without specifying shell. For fin bash use bash only for cli, for others use sh.
@achekulaev achekulaev self-assigned this Jan 4, 2019
@achekulaev achekulaev added this to To do in Docksal 1.12.0 via automation Jan 4, 2019
@achekulaev achekulaev added the size/small Effort in T-Shirt scale label Jan 4, 2019
@achekulaev achekulaev mentioned this issue Jan 4, 2019
Closed
@achekulaev
Copy link
Member Author

Blocks #923

@achekulaev
Copy link
Member Author

Agreed to use sh -l for others for better compatibility and since it's no harm.

achekulaev added a commit that referenced this issue Jan 5, 2019
@achekulaev
Refactor exec internals (Closes #930)
fab8cfe
@lmakarov lmakarov added this to To do in Docksal 1.13.0 via automation Jan 25, 2019
@lmakarov lmakarov removed this from To do in Docksal 1.12.0 Jan 25, 2019
@achekulaev
Copy link
Member Author

Done in #993

Docksal 1.13.0 automation moved this from To do to Done Mar 6, 2019
@achekulaev achekulaev removed this from Done in Docksal 1.13.0 Mar 6, 2019
@achekulaev achekulaev added this to To do in Docksal 1.12.0 via automation Mar 6, 2019
@achekulaev achekulaev reopened this Mar 6, 2019
Docksal 1.12.0 automation moved this from To do to Done Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achekulaev achekulaev

Labels
🏷enhancement size/small Effort in T-Shirt scale
Projects
No open projects
Docksal 1.12.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@achekulaev