Improve performance and functionality of fin bash
#1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 17, 2019 10:17
When running `fin bash`, a special value was passed to `_exec()` which sets the
command to run to an interactive shell. This caused the shell and login scripts
to be started twice, which causes an unnecessary delay before the shell is
available for the user.
This commit changes `_exec()` in the following ways:
* Instead of executing `cd {path}` to switch the working directory, use the
`--workdir` option of `docker exec` instead.
* Consider `__SHELL_INTERACTIVE__` a special case where we only run an
interactive shell without passing a command to run. This cuts time in half
for a `fin bash` invocation.
* Working directory is now also changed for the `web` container (when running
`fin bash web`).
|
@gmta this is an awesome work! |
achekulaev
approved these changes
Dec 17, 2019
Merged
JDDoesDev
added a commit
to JDDoesDev/docksal
that referenced
this pull request
Jun 27, 2021
* 'master' of github.com:docksal/docksal: (171 commits) Updated CONTRIBUTING.md Updated LICENSE year Updated README Updated BLT boilerplate URL Updated CHANGELOG Bump fin v1.93.0 Improved messaging in ssh_key() Added user and shell labels on cli in sercvice.yml Added back xdebug settings workaround for backward compatibility Updated fin run-cli docs Use docker instead of docker-compose for get_project_container_id() (docksal#1246) Improve performance and functionality of `fin bash` (docksal#1247) Fix SSH_AUTH_SOCK being unset for custom commands Revamp of Xdebug docs (docksal#1242) Fix tests Cleanup items pending to be removed as per TODO notes Add IDE_PASSWORD var to IDE stack file (docksal#1241) Updated release data in CHANGELOG Mentioned PHP 7.3 is now the default in CHANGELOG Bump fin 1.92.2 + CHANGELOG update ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
fin bash, a special value was passed to_exec()which sets thecommand to run to an interactive shell. This caused the shell and login scripts
to be started twice, which causes an unnecessary delay before the shell is
available for the user.
This commit changes
_exec()in the following ways:cd {path}to switch the working directory, use the--workdiroption ofdocker execinstead.__SHELL_INTERACTIVE__a special case where we only run aninteractive shell without passing a command to run. This cuts time in half
for a
fin bashinvocation.webcontainer (when runningfin bash web).