Added PHP 7.3 Image #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking as WIP. Currently looks like libzip has been taken out of being compiled and PHP and there isn't a stable version for Stretch currently. There is an unstable version currently but seems to have issues where dependencies are also having trouble compiling. |
|
@achekulaev @lmakarov this is ready for review now. |
lmakarov
requested changes
Dec 31, 2018
There was a problem hiding this comment.
@sean-e-dietrich thanks for working on this!
A few notes and questions:
- Does
unixodbc-devneed to be installed as a runtime dependency? http://take.ms/G1WMQ - I think
zlib1g-devandzlib1gcan be removed in the 7.3Dockerfile, sincelibziprequires those anyway. - "Libzip >= 1.2.0 needed for encryption support" - I think we can ignore this for now.
- Please rebase onto develop and include changes recently merged there.
|
@sean-e-dietrich hold off on rebasing onto develop. It's broken ATM. |
|
We can remove |
# Conflicts: # 5.6/Dockerfile # 7.0/Dockerfile # 7.1/Dockerfile # 7.2/Dockerfile
lmakarov
approved these changes
Jan 4, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in PHP 7.3 image details so that we can start using it for development services. I believe because 7.3 is out currently that it makes sense to include this in our images now.
NOTES
Modules Not Stable
pdo_sqlsrvandsqlsrvare currently not stable for 7.3 and therefore we should make a note of them in the documentation.Known Module Issues
sidbut there are other issues withefreetypewhen attempting to usefreetypeso right now It may be just sufficient to make a note.