SEAB-5183: created notebooks page and added to sitemap #1692
Conversation
hyunnaye
changed the title
|
Will need to wait for dockstore/dockstore#5327 to be merged for the tests to pass |
Codecov ReportBase: 40.77% // Head: 40.78% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1692 +/- ##
========================================
Coverage 40.77% 40.78%
========================================
Files 348 348
Lines 10612 10613 +1
Branches 2719 2719
========================================
+ Hits 4327 4328 +1
Misses 4053 4053
Partials 2232 2232
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| @@ -17,7 +17,12 @@ | |||
| <div fxLayout="row" fxLayoutAlign="start center"> | |||
| <img src="../assets/svg/sub-nav/{{ (entryPageTitle$ | async | titlecase) === 'Services' ? 'services.svg' : 'workflow.svg' }}" /> | |||
There was a problem hiding this comment.
Does this need to be updated? If not, and you're planning to share the same image for notebooks, can you please add a comment or an explicit if condition.
There was a problem hiding this comment.
Yes, it needs to be updated. I'll look for some icons that can be used for notebooks.
There was a problem hiding this comment.
Added a placeholder image (https://fontawesome.com/icons/book?s=solid&f=classic) and set the color to #3f51b5 which is the first Accent 1 colour in zeplin palette https://app.zeplin.io/project/5fc690a2717ee9144814f190/screen/5fc699d068c46f17551f745b
Screenshot of this change is added onto PR description
There was a problem hiding this comment.
Added a placeholder image (https://fontawesome.com/icons/book?s=solid&f=classic) and set the color to
#3f51b5which is the first Accent 1 colour in zeplin palette https://app.zeplin.io/project/5fc690a2717ee9144814f190/screen/5fc699d068c46f17551f745b
By placeholder, do you mean temporary? If yes, can you please create a followup ticket.
If no, would it be possible to use the fontawesome image that we already bundle, like here. That way we don't have to bundle another copy, and it stays in sync/style with the other fontawesome icons if we upgrade the library. The downside is that you would use different HTML for this one case, and maybe we don't want the icon to stay in sync with the other fontawesome icons, we want it to stay in sync with the workflows/services SVGs, so I'm not sure.
There was a problem hiding this comment.
Created ticket dockstore/dockstore#5343
|
SonarCloud Quality Gate failed.
|
Description
Created notebooks page
dockstore.org/notebooksand added the link to the sitemap.Notebooks page
Sitemap
Review Instructions
Verify the new page renders and is implemented correctly and can be accessed from the sitemap.
Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5183
Security
If there are any concerns that require extra attention from the security team, highlight them here.
Please make sure that you've checked the following before submitting your pull request. Thanks!
npm run buildmarkdown-wrappercomponent, which does extra sanitizationnpm auditand ensure you are not introducing new vulnerabilities