Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky tests. #1697

Merged
merged 3 commits into from Feb 1, 2023
Merged

Fix flaky tests. #1697

merged 3 commits into from Feb 1, 2023

Conversation

coverbeck
Copy link
Contributor

@coverbeck coverbeck commented Jan 31, 2023

Description
It was failing when running locally about 50% of the time. With the "fix", ran 10 times in a row without an error.

Review Instructions
UI checks on the develop branch should always pass.

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5217

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

https://ucsc-cgl.atlassian.net/browse/SEAB-5217

It was failing when running locally about 50% of the time. With the
"fix", ran 10 times in a row without an error.
@coverbeck coverbeck self-assigned this Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 40.73% // Head: 40.73% // No change to project coverage 👍

Coverage data is based on head (71c7b2f) compared to base (7dd11b7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1697   +/-   ##
========================================
  Coverage    40.73%   40.73%           
========================================
  Files          348      348           
  Lines        10599    10599           
  Branches      2718     2718           
========================================
  Hits          4317     4317           
  Misses        4051     4051           
  Partials      2231     2231           
Impacted Files Coverage Δ
...me-page/home-logged-in/home-logged-in.component.ts 54.54% <0.00%> (-4.55%) ⬇️
...rc/app/home-page/home-logged-out/home.component.ts 68.42% <0.00%> (+2.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Feb 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coverbeck
Copy link
Contributor Author

I think I found a better fix, re-requesting review.

@coverbeck coverbeck merged commit a29c60b into develop Feb 1, 2023
@coverbeck coverbeck deleted the feature/seab-5217/flaky branch February 1, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants