Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky tests. #1697

Merged
merged 3 commits into from Feb 1, 2023
Merged

Fix flaky tests. #1697

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ac15b4
Fix flaky tests.
coverbeck Jan 31, 2023
df5d6be
Whoops, wrong branch pulled in
coverbeck Jan 31, 2023
71c7b2f
Better fix.
coverbeck Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions cypress/e2e/group3/githubAppTools.ts
View file
Open in desktop
Expand Up @@ -142,6 +142,11 @@ describe('GitHub App Tools', () => {

selectGitHubAppTool('test-github-app-tools/md5sum');
cy.get('[data-cy=viewPublicWorkflowButton]').click();

// Look for something that is on public page that is not in My Tools; avoids detached DOM when clicking on versions below; also
// ensures the subsequent checks below are checking the public page and not the My Tools Page
cy.get('app-launch-third-party');

cy.get('[data-cy=tool-icon]').should('exist');
cy.contains('Tool Information');
cy.contains('Tool Version Information');
Expand Down