Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCK-2449: Enable wrapping when viewing files #1836

Merged
merged 1 commit into from
Aug 25, 2023
Merged

DOCK-2449: Enable wrapping when viewing files #1836

merged 1 commit into from
Aug 25, 2023

Conversation

y-ng
Copy link
Collaborator

@y-ng y-ng commented Aug 25, 2023

Description
This PR enables word wrapping in the ace code editor so that long lines are easier to navigate when viewing files (here the line length and formatting are preserved in case the file is being edited).

Before:
Screenshot from 2023-08-25 15-18-20

After:
Screenshot from 2023-08-25 15-17-32

Review Instructions
Go to a workflow/tool/notebook, click on the Files tab, and check that long lines of text/code wrap around.

Issue
DOCK-2449

Security
If there are any concerns that require extra attention from the security team, highlight them here.

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

@y-ng y-ng self-assigned this Aug 25, 2023
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (be9db45) 40.69% compared to head (133a282) 40.70%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1836   +/-   ##
========================================
  Coverage    40.69%   40.70%           
========================================
  Files          364      364           
  Lines        11252    11252           
  Branches      2866     2866           
========================================
+ Hits          4579     4580    +1     
  Misses        4377     4377           
+ Partials      2296     2295    -1     
Files Changed Coverage Δ
...rc/app/shared/code-editor/code-editor.component.ts 20.65% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@y-ng y-ng requested review from a team, david4096, hyunnaye, svonworl, coverbeck, denis-yuen and kathy-t and removed request for a team August 25, 2023 19:34
@y-ng y-ng merged commit 6b02dae into develop Aug 25, 2023
9 checks passed
@y-ng y-ng deleted the DOCK-2449 branch August 25, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants