Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEAB-5951: Add GitHub logo image #1868

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

svonworl
Copy link
Contributor

@svonworl svonworl commented Nov 7, 2023

Description
After #1865 was merged, Charles noticed that the GitHub logo image in the "Launch with" block was broken. This happened because said logo image was inadvertently not added by the previous PR. This PR adds it.

Review Instructions
Same checks as #1865

Issue
https://ucsc-cgl.atlassian.net/browse/SEAB-5951

Please make sure that you've checked the following before submitting your pull request. Thanks!

  • Check that your code compiles by running npm run build
  • Ensure that the PR targets the correct branch. Check the milestone or fix version of the ticket.
  • If this is the first time you're submitting a PR or even if you just need a refresher, consider reviewing our style guide
  • Do not bypass Angular sanitization (bypassSecurityTrustHtml, etc.), or justify why you need to do so
  • If displaying markdown, use the markdown-wrapper component, which does extra sanitization
  • Do not use cookies, although this may change in the future
  • Run npm audit and ensure you are not introducing new vulnerabilities
  • Do due diligence on new 3rd party libraries, checking for CVEs
  • Don't allow user-uploaded images to be served from the Dockstore domain
  • If this PR is for a user-facing feature, create and link a documentation ticket for this feature (usually in the same milestone as the linked issue). Style points if you create a documentation PR directly and link that instead.
  • Check whether this PR disables tests. If it legitimately needs to disable a test, create a new ticket to re-enable it in a specific milestone.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d1e1f9) 40.35% compared to head (ef82d2f) 40.35%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1868   +/-   ##
========================================
  Coverage    40.35%   40.35%           
========================================
  Files          367      367           
  Lines        11410    11410           
  Branches      2924     2924           
========================================
  Hits          4605     4605           
- Misses        4484     4485    +1     
+ Partials      2321     2320    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svonworl svonworl merged commit 993d898 into develop Nov 7, 2023
17 of 18 checks passed
@svonworl svonworl deleted the feature/seab-5951/add-github-logo-image branch November 7, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants