Relax rules for Amazon ECR tools

[garyluu]

Describe the bug
It's currently difficult to register tools with Amazon ECR because of aggressive checks (both backend and frontend)

To Reproduce
Steps to reproduce the behavior:

1. Register tool with remote site
2. Choose Amazon ECR
3. Try registering with something like https://gallery.ecr.aws/x5g7o3i3/appropriate/curl
4. See sanity check errors in both the Image Registry and Docker Registry Path

Expected behavior
Should be able to register a tool using an Amazon ECR image like https://gallery.ecr.aws/x5g7o3i3/appropriate/curl

Additional context
Webservice - 1.10.2

UI - 2.7.4

Compose Setup - 1.1

Deploy - 1.10.1

┆Issue is synchronized with this Jira Story
┆fixVersions: Dockstore 1.12
┆friendlyId: DOCK-1815
┆sprint: Sprint 65-Pyjama shark
┆taskType: Story

[pgroves]

(I originally brought up this issue on the Discourse forum)

You could also consider a 'catch all' option that takes any valid docker url, which is the underlying requirement of wdl. For instance, we have some old images like: hub.ncsa.illinois.edu/phyloflow/pyclone hosted on our own hub. I don't think it makes sense for dockstore to try to hardcode a menu option for every small hub like that.

Thank you for your fast response.

[unito-bot]

➤ Denis Yuen commented:

https://oicr.slack.com/archives/C3A3KRT2B/p1623104357002700 ( https://oicr.slack.com/archives/C3A3KRT2B/p1623104357002700|smart-card )

[unito-bot]

➤ Denis Yuen commented:

There are three main tasks, which will need to be split up

1. Workflows can point at ECR tools, make sure these work with features like checksum harvesting or digests. Also take a look at the tools tab or the dag tab which display names of Docker images used by a workflow
2. Tools on Dockstore should already have the ability to be registered based on ECR, but the regular expression is probably too strict based on the newer version of ECR
3. Peter Grove (below) ran into an example with a “custom” Docker hub. We’ll need to brainstorm/storytime this one

[unito-bot]

➤ Kathy.Tran commented:

This ticket implements part 1. For part 1, finish getting tools tab and dag tab so they display the names of the images.

Checksum harvesting for public registries is split out into another ticket ( #4330 ) (requires more brainstorming).

For this ticket (part 1), can also add to docs that we couldn’t implement checksum harvesting for ECR images after some research.

Part 2 is split into another ticket ( #4331 ).

Part 3 is split into a completely different ticket ( #4332 ) (unrelated to Amazon ECR).

[NatalieEO]

Registered a tool that used an amazon ecr image and was able to see it appear in the DAG and Tools tabs
Webservice - 93a88e0

UI - 2.8-44-g95bc00b5

Compose Setup - abf5bef

Deploy - 1.11.0-30-gb6b2d89