Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tools from public and private Amazon ECR to be registered #4331

Closed
kathy-t opened this issue Jun 29, 2021 · 2 comments
Closed

Allow tools from public and private Amazon ECR to be registered #4331

kathy-t opened this issue Jun 29, 2021 · 2 comments
Assignees
Labels
enhancement gui Issues related to the current GUI. review merged but pending a third party look at whether it makes sense/is working web-service
Milestone

Comments

@kathy-t
Copy link
Contributor

kathy-t commented Jun 29, 2021

Split out from #4283 (part 2). The regular expression for Amazon ECR currently doesn't support public Amazon ECR and it may be too strict.

┆Issue is synchronized with this Jira Story
┆fixVersions: Dockstore 1.12
┆friendlyId: DOCK-1844
┆sprint: Sprint 69- Tiger shark
┆taskType: Story

@kathy-t kathy-t added the bug label Jun 29, 2021
@kathy-t kathy-t self-assigned this Jun 29, 2021
@denis-yuen denis-yuen added this to the 1.12 milestone Jun 30, 2021
@denis-yuen denis-yuen added enhancement gui Issues related to the current GUI. web-service and removed bug labels Jun 30, 2021
kathy-t added a commit that referenced this issue Aug 26, 2021
Webservice portion of #4331 
* Allow public and private Amazon ECR tools to be registered
@unito-bot unito-bot added the review merged but pending a third party look at whether it makes sense/is working label Aug 31, 2021
@unito-bot
Copy link

➤ Kathy.Tran commented:

Webservice PR: #4420 ( https://github.com/dockstore/dockstore/pull/4420|smart-link )

UI PR: dockstore/dockstore-ui2#1339 ( https://github.com/dockstore/dockstore-ui2/pull/1339|smart-link )

Notes to reviewer:

  • Test that you can register a public and private Amazon ECR tool in the UI
  • Test that you can register a public and private hosted Amazon ECR tool in the UI
  • Amazon ECR image repositories can contain multiple slashes, like foo/bar/potato. Test that when registering an Amazon ECR tool, you can use an image repository that contains multiple slashes

@unito-bot
Copy link

➤ Denis Yuen commented:

Was able to create public and private Amazon ECR tools both from external source control

Was able to create both for hosted workflows

Was able to create docker images with multiple slashes (which still seems like a bad idea, but thats on Amazon)

Thanks for being so thorough!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement gui Issues related to the current GUI. review merged but pending a third party look at whether it makes sense/is working web-service
Projects
None yet
Development

No branches or pull requests

3 participants