Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enable Network Discovery and File Sharing by default (#420) #421

Merged
merged 25 commits into from
Apr 26, 2024

Conversation

hellodword
Copy link
Contributor

@hellodword
Copy link
Contributor Author

hellodword commented Apr 26, 2024

@kroese This may cause security issues for normal users, I guess we should create a switch in the qemu image? Like:

if /storage/shared is mounted
   enable it
else
   disable it

I'm not familiar with the qemu layer of dockur, how do you think?

@hellodword
Copy link
Contributor Author

And based on this feature, I want to create a new feature, it looks like:

        <SynchronousCommand>
          <Order>201</Order>
          <CommandLine>powershell.exe -sta -ExecutionPolicy Bypass -Command "\\host.lan\Data\FirstLogonCommands\sta\run-custom.ps1 *> C:\output-201.log"</CommandLine>
          <Description>run custom</Description>
        </SynchronousCommand>

loop the \\host.lan\Data\FirstLogonCommands and execute all of them(bat, ps1, and so on)

It'll improve the automation usage of dockur a lot. For example, all the #187 related users are able to always use the latest version of dockur, without maintaining a modified and outdated win11x64.xml locally.

How do you think? Once the security issue of this PR been solved, I'd love to create a draft PR for this :)

@kroese
Copy link
Contributor

kroese commented Apr 26, 2024

@hellodword It should not create any security issue while the container is in a bridge network (the default). Because no ports are forwarded in the compose file to allow Samba access, so other computers in the LAN can never access the machine, even with with Network Discovery / File Sharing enabled.

So unless somebody manually forwards the ports in bridge mode or puts the container in macvlan it will not be a problem.

@hellodword
Copy link
Contributor Author

Great, glad to know that :)

@kroese kroese merged commit 638e21d into dockur:master Apr 26, 2024
1 check passed
renovate bot added a commit to NorkzYT/Wolflith that referenced this pull request Apr 30, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change | Pending |
|---|---|---|---|
| [dockurr/windows](https://togithub.com/dockur/windows) | minor |
`2.19` -> `2.20` | `2.22` (+1) |

---

### Release Notes

<details>
<summary>dockur/windows (dockurr/windows)</summary>

### [`v2.20`](https://togithub.com/dockur/windows/releases/tag/v2.20)

[Compare
Source](https://togithub.com/dockur/windows/compare/v2.19...v2.20)

#### What's Changed

- fix: Enable Network Discovery and File Sharing by default
([#&#8203;420](https://togithub.com/dockur/windows/issues/420)) by
[@&#8203;hellodword](https://togithub.com/hellodword) in
[dockur/windows#421
- docs: Custom XML instructions by
[@&#8203;kroese](https://togithub.com/kroese) in
[dockur/windows#424
- feat: Enable file sharing by default by
[@&#8203;kroese](https://togithub.com/kroese) in
[dockur/windows#425
- docs: Update issue templates by
[@&#8203;kroese](https://togithub.com/kroese) in
[dockur/windows#427

#### New Contributors

- [@&#8203;hellodword](https://togithub.com/hellodword) made their first
contribution in
[dockur/windows#421

**Full Changelog**:
dockur/windows@v2.19...v2.20

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,every
weekend,before 5am every weekday" in timezone America/New_York,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/NorkzYT/Wolflith).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMjEuMiIsInVwZGF0ZWRJblZlciI6IjM3LjMyMS4yIiwidGFyZ2V0QnJhbmNoIjoic3RhZ2luZyIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJtaW5vciIsInJlbm92YXRlIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot access shared folder "Windows cannot access \\host.lan\Data"
2 participants