Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-sass to 2.1.1 #27

Closed
wants to merge 1 commit into from

Conversation

waldher
Copy link

@waldher waldher commented Apr 28, 2015

In order to resolve the issue with sass/node-sass#653, node-sass needs to be upgraded to at least 2.0.1, so I'm upgrading to the current version of 2.1.1.

Running 'cake test' after upgrading node-sass was successful:

`--> cake test

> docpad-plugin-nodesass@2.5.1 test /tmp/docpad-plugin-nodesass
> node ./out/sass.test.js

nodesass plugin
nodesass plugin ➞  create
notice: If everyone who saw this message donated $1/week, maintaining DocPad would become sustainable: http://docpad.org/donate
nodesass plugin ➞  create ✔   
nodesass plugin ➞  load plugin nodesass
nodesass plugin ➞  load plugin nodesass ✔   
nodesass plugin ➞  generate
nodesass plugin ➞  generate ➞  action
OK

@barlock
Copy link
Collaborator

barlock commented May 6, 2015

The api from 1.2.3 updated in 2.x.x so the plugin requires some work to do the update. The current master branch doesn't run tests like its supposed to. I've made a pull request to update the base files to make the tests run again and I should have another pull request based on those files to update to 2.1.1 by end of day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants