Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve English wording (Getting Started/Customization) #1617

Merged
merged 1 commit into from
Jul 30, 2021
Merged

docs: improve English wording (Getting Started/Customization) #1617

merged 1 commit into from
Jul 30, 2021

Conversation

johnjago
Copy link
Contributor

While referencing the documentation, I noticed a few phrases that could
be changed to sound more natural. I tried to keep the original meanings.

Summary

This change improves the phrasing of the English translation of the documentation. It uses more natural sounding English phrases. Only two sections are covered in this PR: the Getting Started and Customization sections.

No UI changes.

What kind of change does this PR introduce?

Docs

For any code change,

  • Related documentation has been updated if needed
  • Related tests have been updated or tests have been added

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Related issue, if any:

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

While referencing the documentation, I noticed a few phrases that could
be changed to sound more natural. I tried to keep the original meanings.
@vercel
Copy link

vercel bot commented Jul 29, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/AaxZwR3NxgY6VFqAYEgnRMWGv54w
✅ Preview: https://docsify-preview-git-fork-johnjago-improve-wording-docsify-core.vercel.app

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3527094:

Sandbox Source
docsify-template Configuration

@sy-records sy-records requested a review from a team July 30, 2021 01:30
Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@sy-records sy-records requested a review from a team July 30, 2021 01:32
@sy-records sy-records merged commit 97806cb into docsifyjs:develop Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants