Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the end condition for the embed content handling loop #1824

Merged
merged 8 commits into from
May 18, 2023
Merged

Fix the end condition for the embed content handling loop #1824

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
95f5c45
Fix the end condition for the embed content handling loop
julienw Jun 22, 2022
8fe876a
Merge branch 'develop' into fix-non-asynchronous-embeds
Koooooo-7 Dec 14, 2022
ead6519
Merge branch 'develop' into fix-non-asynchronous-embeds
Koooooo-7 Dec 16, 2022
88345bd
Merge branch 'develop' into fix-non-asynchronous-embeds
Koooooo-7 Jan 3, 2023
f9b6ca1
Merge branch 'develop' into fix-non-asynchronous-embeds
Koooooo-7 May 1, 2023
51a7230
Merge branch 'develop' into fix-non-asynchronous-embeds
Koooooo-7 May 4, 2023
d3b0d3d
Merge branch 'develop' into fix-non-asynchronous-embeds
Koooooo-7 May 10, 2023
73dc6d6
Merge branch 'develop' into fix-non-asynchronous-embeds
Koooooo-7 May 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/render/embed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const cached = {};
function walkFetchEmbed({ embedTokens, compile, fetch }, cb) {
let token;
let step = 0;
let count = 1;
let count = 0;

if (!embedTokens.length) {
return cb({});
Expand Down Expand Up @@ -73,7 +73,7 @@ function walkFetchEmbed({ embedTokens, compile, fetch }, cb) {
}

cb({ token, embedToken });
if (++count >= step) {
if (++count >= embedTokens.length) {
cb({});
}
};
Expand Down