Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump tough-cookie from 4.1.2 to 4.1.3 #2121

Merged
merged 1 commit into from Jul 17, 2023
Merged

chore: bump tough-cookie from 4.1.2 to 4.1.3 #2121

merged 1 commit into from Jul 17, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 9, 2023 •
edited

Bumps tough-cookie from 4.1.2 to 4.1.3.

Release notes

Sourced from tough-cookie's releases.

4.1.3

Security fix for Prototype Pollution discovery in #282. This is a minor release, although output from the inspect utility is affected by this change, we felt this change was important enough to be pushed into the next patch.

Commits
  • 4ff4d29 4.1.3 release preparation, update the package and lib/version to 4.1.3. (#284)
  • 12d4747 Prevent prototype pollution in cookie memstore (#283)
  • f06b72d Fix documentation for store.findCookies, missing allowSpecialUseDomain proper...
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 9, 2023
@vercel
Copy link

vercel bot commented Jul 9, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2023 11:18pm

@Koooooo-7
Copy link
Member

Marked failed, need check sandbox status.

@trusktr
Copy link
Member

trusktr commented Jul 11, 2023

Updating patch versions of every dependency is a lot of noise. Probably overkill.

I propose we reduce the noise by removing package-lock.json, and instead we can rely on semver in package.json. Then, we use npm install in CI, and if something breaks, we'll know. We will also still have snyk to advise of security issues (but Docsify is a static library, so there really isn't much of a security concern by default).

@trusktr trusktr closed this Jul 11, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 11, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@trusktr trusktr deleted the dependabot/npm_and_yarn/tough-cookie-4.1.3 branch July 11, 2023 20:41
@sy-records
Copy link
Member

@dependabot reopen

@dependabot dependabot bot reopened this Jul 17, 2023
@dependabot dependabot bot restored the dependabot/npm_and_yarn/tough-cookie-4.1.3 branch July 17, 2023 23:17
@dependabot @sy-records
chore: bump tough-cookie from 4.1.2 to 4.1.3
80bd5c4 
Bumps [tough-cookie](https://github.com/salesforce/tough-cookie) from 4.1.2 to 4.1.3.
- [Release notes](https://github.com/salesforce/tough-cookie/releases)
- [Changelog](https://github.com/salesforce/tough-cookie/blob/master/CHANGELOG.md)
- [Commits](salesforce/tough-cookie@v4.1.2...v4.1.3)

---
updated-dependencies:
- dependency-name: tough-cookie
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@sy-records sy-records force-pushed the dependabot/npm_and_yarn/tough-cookie-4.1.3 branch from 0866328 to 80bd5c4 Compare July 17, 2023 23:18
@sy-records sy-records merged commit b9eef99 into develop Jul 17, 2023
9 checks passed
@sy-records sy-records deleted the dependabot/npm_and_yarn/tough-cookie-4.1.3 branch July 17, 2023 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sy-records sy-records sy-records approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Koooooo-7 @trusktr @sy-records