Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade marked from 12.0.2 to 13.0.2 #2467

Merged
merged 6 commits into from
Jul 22, 2024
Merged

chore: upgrade marked from 12.0.2 to 13.0.2 #2467

merged 6 commits into from
Jul 22, 2024

Conversation

Koooooo-7
Copy link
Member

@Koooooo-7 Koooooo-7 commented Jul 17, 2024

Summary

Since the markedjs release to v13, all the renderer's params change to TOKENS instead of the pre versions' behaviors.
So, we need manually build the contents as the default renderer of markedjs in pre versions to get
those contents which we need.

Refer

The default renderer impl of markedjs markedjs/Renderer.ts
The changes before the v13. markedjs/Instance.ts
The new params for each TOKEN. markedjs/Tokens.ts

close #2461

Related issue, if any:

What kind of change does this PR introduce?

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

Yes
No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2024 8:22am

@Koooooo-7 Koooooo-7 marked this pull request as ready for review July 18, 2024 15:43
@Koooooo-7 Koooooo-7 requested a review from a team July 18, 2024 15:44
Copy link
Member

@jhildenbiddle jhildenbiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Happy to see now tests or snapshots needed to be updated :).

@sy-records sy-records merged commit 49f5c56 into develop Jul 22, 2024
9 checks passed
@sy-records sy-records changed the title chore: upgrade marked from 12.0.2 to 13.0.2 adoption chore: upgrade marked from 12.0.2 to 13.0.2 Jul 22, 2024
@sy-records sy-records deleted the marked-v13 branch July 22, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants