Fixed toc labels for members #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed logic that changins the toc id name based on '~' or '.' syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When clicking on any class member toc item, the url anchor name shows up as one of those fallback auto-generated names like
"toc2_anchor"instead of the correct member id. It seems the problem was that the id was never added to the header element.I also removed the logic that replaced the
~and.symbols from the member anchor's with-inner-and-static-respectively. I added this some time ago in a previous pull request to solve a problem I was having, but it makes better sense now to remove it as it doesn't match up with the alternate anchor for the same link.