provide alternative implementation of has_insertion_operator for C++20 #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
original implementation couldn't handle explicitly deleted operator<<(ostream, X) overloads introduced in C++20
|
Thanks for this - all builds passed! (including the ones which didn't show up in here: https://travis-ci.org/github/onqtam/doctest/builds/697205413 ) |
onqtam
pushed a commit
that referenced
this pull request
Jun 27, 2020
original implementation couldn't handle explicitly deleted operator<<(ostream, X) overloads introduced in C++20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
in C++20 a subset of
operator<<(std::ostream&, X)overloads were explicitly deleted. Using types from deleted operators cause compilation failure ofhas_insertion_operatorGitHub Issues
this PR is direct outcome of the discussion from #357 it also helps to solve USCiLab/cereal#638