Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subcase reentry #598

Merged
merged 6 commits into from
Apr 25, 2022
Merged

Fix subcase reentry #598

merged 6 commits into from
Apr 25, 2022

Conversation

Saalvage
Copy link
Member

@Saalvage Saalvage commented Jan 22, 2022 •
edited

TODO:

  • Encapsulate the subcase matcher and move it down
  • Replace current stack by an index into the max stack

Closes #597

@Saalvage Saalvage marked this pull request as ready for review April 23, 2022 19:52
@codecov
Copy link

codecov bot commented Apr 23, 2022 •
edited

Codecov Report

Merging #598 (ae59e85) into dev (0b79b49) will increase coverage by 0.03%.
The diff coverage is 97.26%.

@@            Coverage Diff             @@
##              dev     #598      +/-   ##
==========================================
+ Coverage   93.04%   93.07%   +0.03%     
==========================================
  Files           2        2              
  Lines        2085     2124      +39     
==========================================
+ Hits         1940     1977      +37     
- Misses        145      147       +2
Impacted Files Coverage Δ
doctest/parts/doctest_fwd.h 97.53% <ø> (ø)
doctest/parts/doctest.cpp 92.71% <97.26%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b79b49...ae59e85. Read the comment docs.

@Saalvage Saalvage merged commit eb8b04a into dev Apr 25, 2022
@Saalvage Saalvage deleted the fix-subcase-reentry branch April 25, 2022 09:01
hurricane1026 pushed a commit to clapdb/doctest that referenced this pull request Nov 3, 2022
@Saalvage @hurricane1026
Fix subcase reentry (doctest#598)
2faca82 
* Add tests

* Fix doctest#597

* Slightly alternate approach to subcases

* Replace usage of non-standard contains method

* Merge branch 'dev' into fix-subcase-reentry
patstew added a commit to patstew/doctest that referenced this pull request Sep 7, 2023
@patstew
Only call subcase_end currentSubcaseDepth times
6d3b16d 
Fix doctest#803, presumably broken since doctest#598
patstew added a commit to patstew/doctest that referenced this pull request Sep 7, 2023
@patstew
Only call subcase_end currentSubcaseDepth times
57c2840 
Fix doctest#803, presumably broken since doctest#598
@patstew patstew mentioned this pull request Sep 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Saalvage