This repository has been archived by the owner on Jul 12, 2024. It is now read-only.
test and solve cases of find with multiple ids #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| base1 = BaseTest.create!(name: 'joe1') | ||
| base2 = BaseTest.create!(name: 'joe2') | ||
| base3 = BaseTest.create!(name: 'joe3') | ||
| expect(BaseTest.find([base1.id, 't', 't', base2.id, base3.id], quiet: true)).to eq([base1, base2, base3]) |
There was a problem hiding this comment.
Should we make sure that the ids returned by the find are not replaced? Since we add the ids here: https://github.com/doctolib/couchbase-orm/pull/19/files#diff-7cab7700be71ff406f6ca75d7f60cbec51ab79649fab7d39df67893225d7247aR257
Or is it already covered by the eq([base1, base2, base3])?
There was a problem hiding this comment.
for me eq covered it but i'm not an expert of ruby
There was a problem hiding this comment.
Can you try running it without your changes? If it still passes, I would say we are missing an assertion somewhere, if it fails we should be good
There was a problem hiding this comment.
The new test without the functional change is breaking some new test. So it's ok.
pimpin
reviewed
Apr 12, 2023
Co-authored-by: Pierre Merlin <pimpin@users.noreply.github.com>
fabio-guerreiro
approved these changes
Apr 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when we find with multiple ids and if some of them doesn't have document in couchbase the result is not coherent.