Fix SQL syntax highlight on Symfony 6.3 #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
force-pushed
the
fix-highlight-on-sf-6.3
branch
from
67eb2d5
to
a75e038
Compare
javiereguiluz
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Thanks @HypeMC!
I agree with you that it's not a big deal to includes these CSS styles twice in 6.2.
ostrolucky
approved these changes
Jun 28, 2023
dmaicher
approved these changes
Jun 28, 2023
|
Thanks @HypeMC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQL syntax highlighting is broken on Symfony 6.3:
The CSS was removed in symfony/symfony#48757 (symfony/symfony@b5a10ce).
Since the idea of the PR was to move panel specific styles to their respective template files, it'd make sense to move this CSS to the Doctrine bundle. The only problem with this approach is that on Symfony 6.2 the CSS would be displayed twice, once by Symfony's WebProfilerBundle and once by the DoctrineBundle. I don't think that's a big issue however.
Maybe @javiereguiluz has some input?