[WebProfilerBundle] Move panel specific styles to each panel #48757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Dec 22, 2022
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig
Outdated
Show resolved
Hide resolved
| margin-bottom: 0; | ||
| padding: 0; | ||
| } | ||
| #collector-content .sf-validator .trace li.selected { |
There was a problem hiding this comment.
Those styles are almost a copy/paste of the serializer and messenger ones (except the panel selector). This makes me think it might deserve a reusable component in the main styles instead of re-creating this rendering for each panel that has such a structure (and third-party bundles might also have a similar panel btw and would benefit from it)
There was a problem hiding this comment.
OK; but let's do it in a separate PR, please. Thanks.
javiereguiluz
force-pushed
the
profiler_styles
branch
from
c81478d
to
c43cfdf
Compare
|
@javiereguiluz Can you resolve the conflicts? |
javiereguiluz
force-pushed
the
profiler_styles
branch
from
b31d47f
to
507f2d7
Compare
|
I've rebased this PR. Thanks. |
fabpot
approved these changes
Jan 24, 2023
|
Thank you @javiereguiluz. |
fabpot
force-pushed
the
profiler_styles
branch
from
507f2d7
to
4c2375e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @stof during the last profiler redesign, we should move specific panel styles to each panel, to ease the maintenance of the main CSS file.