Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom repository service compiler pass #658

Closed
wants to merge 8 commits into from
Closed

Custom repository service compiler pass #658

wants to merge 8 commits into from

Commits on Jun 1, 2017

  1. Added a compiler pass to register custom repositories as services, 

    given they only belong only to one entity manager. In accordance with
Symfony 3.3 standards, the service name is the class name of the repository.
    @magnusnordlander
    magnusnordlander committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    59de284 View commit details
    Browse the repository at this point in the history

  2. Don’t overwrite existing services

    @magnusnordlander
    magnusnordlander committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    1b8d2a3 View commit details
    Browse the repository at this point in the history

  3. Style change

    @magnusnordlander
    magnusnordlander committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    9556520 View commit details
    Browse the repository at this point in the history

  4. Updated to make services private, add logging, and to abort registrat… 

    …ion if there are already services for a given repository (and we’re not on Sf >=4.0).
    @magnusnordlander
    magnusnordlander committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    3a92081 View commit details
    Browse the repository at this point in the history

  5. Added some tests, fixed a bug when using multiple EMs.

    @magnusnordlander
    magnusnordlander committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    a7a5067 View commit details
    Browse the repository at this point in the history

  6. Fixed regressions and improved tests

    @magnusnordlander
    magnusnordlander committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    d590bd2 View commit details
    Browse the repository at this point in the history

  7. Modified skipped test

    @magnusnordlander
    magnusnordlander committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    f253c1c View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2017

  1. Review fixes

    @magnusnordlander
    magnusnordlander committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    6d31693 View commit details
    Browse the repository at this point in the history