6.0.2 regex change is too restrictive

[Novynn]

This change (#806) is breaking things. An example is: annotation methods are cached by Doctrine using a hash symbol (ie. #) which isn't included in the regex.

The initial regex that was breaking the tests in doctrine/DoctrineORMModule#734 is only relevant to the "Filesystem" storage adapter.

https://github.com/laminas/laminas-cache-storage-adapter-filesystem/blob/d78283f47a7d0fd3968c63836ee2805b53bff06f/src/FilesystemOptions.php#L27

[TomHAnderson]

Can you give a full key that uses the hash?

[Novynn]

The hash is used here:

https://github.com/doctrine/annotations/blob/4b68cf86b766ec429f4f68af648817cdfb360582/lib/Doctrine/Common/Annotations/PsrCachedReader.php#L113

[TomHAnderson]

As @Novynn has pointed out, /^[a-z0-9_\+\-\[\]\\\\$]*$/Di is the regex for the Filesystem cache. Because that's the case does it make sense to include a regex for each cache?

[demiankatz]

Good point, I'll fix it.

[demiankatz]

See #809. This should be a more focused fix now, and it also has test coverage. Thanks, @Novynn!

[Novynn]

Thank you to @TomHAnderson and @demiankatz for sorting this out. Moving the filter to the filesystem has solved any concerns I had as we don't use the adapter. I'm sure using the filesystem to cache has all kinds of restrictions.