Add support for # in cache key; add test. #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
force-pushed
the
more-cache-improvements
branch
from
3c971d0
to
e991da3
Compare
demiankatz
force-pushed
the
more-cache-improvements
branch
from
e991da3
to
9eea9a7
Compare
|
This should be ready for merge, @TomHAnderson, unless @Novynn is aware of any additional characters that should be added to the regex and corresponding test. |
TomHAnderson
approved these changes
Jun 9, 2023
|
If further followup is needed, I'm happy to help, time permitting. I hope to spend some time in the next couple of weeks integrating this into my own application, so hopefully that will help turn up any remaining issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #806. Resolves #807.