sanity-check DI configuration #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it does not adress the feature request to split configuration between connection configuration and document manager: https://github.com/doctrine/DoctrineMongoDBBundle/pull/184/files#r3856315 but i think everything else is covered, yes. |
|
@jmikola this one is old. still want to merge it maybe? |
|
@dbu Sorry for the long delay, can you rebase this once again? |
|
just did the rebase. hope it still ends up green. |
|
Thanks! |
|
you are welcome!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redoing #184 as i already deleted my fork and thus can't update the PR anymore.
moved validation into Configuration instead of the extension class.