[Security] Ensure DocumentUserProvider::refreshUser() uses id #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a security vulnerability in the DocumentUserProvider where a user might be refreshed by username, which could have been altered during form binding and failed validation. Apart from this fix, it's wise to clone the managed user object before using it in a form if it is also being tracked in security context. Furthermore, you should be careful not to allow document identifiers to be modified by untrusted forms. See: * http://symfony.com/blog/security-release-symfony-2-0-6 * symfony/symfony@9d2ab9c
stof
added a commit
that referenced
this pull request
Nov 16, 2011
[Security] Ensure DocumentUserProvider::refreshUser() uses id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of @fabpot's security fix for the Doctrine Bridge: http://symfony.com/blog/security-release-symfony-2-0-6