Add section for Messenger integration #637
Conversation
Resources/doc/messenger.rst
Outdated
| @@ -0,0 +1,11 @@ | |||
| Messenger integration | |||
There was a problem hiding this comment.
Capitalize "Integration" since this is a title.
Resources/doc/messenger.rst
Outdated
|
|
||
| .. note:: | ||
|
|
||
| The middleware is available when using Symfony 4.4 or newer |
There was a problem hiding this comment.
Let's work this into the previous paragraph.
When using Symfony 4.4 or later, the bundle automatically registers...
Resources/doc/messenger.rst
Outdated
| ===================== | ||
|
|
||
| The bundle automatically registers a `Messenger`_ middleware that clears | ||
| document managers between messages being handled to avoid outdated data. |
There was a problem hiding this comment.
Suggestion:
...that clears all document managers after handling messages, which helps to isolate each handler and guard against reading out-of-date document data.
I summarized that from @weaverryan's explanation in symfony/symfony#34156. You could also considering adding a link to the issue for more context, since there isn't much else to say on this page, but I don't feel strongly either way about that.
There was a problem hiding this comment.
Dang, now I see it's not even a middleware but rather a event subscriber 👀 I'll go with your summary
There was a problem hiding this comment.
Looking at the Symfony PR, I think the design changed somewhere along the way. In any event, current text LGTM.
Closes #634