Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PSR/Log v2 and v3 #704

Merged
merged 1 commit into from Oct 9, 2021
Merged

Allow PSR/Log v2 and v3 #704

merged 1 commit into from Oct 9, 2021

Conversation

IonBazan
Copy link
Member

@IonBazan IonBazan commented Oct 6, 2021

PSR logger is only used in PSRCommandLogger: https://github.com/doctrine/DoctrineMongoDBBundle/blob/4.4.x/APM/PSRCommandLogger.php

Since we are only calling debug() method and not relying on any of return types, we can safely allow installing all versions of psr/log without any changes in code.

@IonBazan IonBazan requested a review from a team October 6, 2021 06:58
@IonBazan IonBazan self-assigned this Oct 6, 2021
@IonBazan IonBazan added this to the 4.4.0 milestone Oct 6, 2021
@IonBazan IonBazan added this to 4.4 (in development) in Roadmap Oct 6, 2021
@IonBazan IonBazan merged commit 6ac19e0 into doctrine:4.4.x Oct 9, 2021
@IonBazan IonBazan deleted the new-psr-log branch October 9, 2021 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
4.4 (in development)
Development

Successfully merging this pull request may close these issues.

None yet

2 participants