Mark all command and compiler pass classes as final #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
force-pushed
the
command-internal
branch
from
1a89cf4
to
f99da5f
Compare
franmomu
approved these changes
Dec 9, 2023
|
@franmomu maybe we should mark them internal in 4.7 and final in 5.0. So this breaking change can be reported before upgrading to the major version. |
yeah, we should warn users 👍 |
GromNaN
changed the title
GromNaN
force-pushed
the
command-internal
branch
from
f99da5f
to
b9a8a0e
Compare
|
The classes are now internal in 4.7, and this PR mark them as final in 5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the commands are glue code for Doctrine features. If some needs to change the behavior of a command, they can duplicate the code.
Maintenance is a lot easier when this classes are marked internal, as we don't have to keep backward-compatibility.