Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cs: apply doctrine coding standard #226

Merged
merged 1 commit into from Oct 30, 2020
Merged

cs: apply doctrine coding standard #226

merged 1 commit into from Oct 30, 2020

Conversation

rieschl
Copy link
Contributor

@rieschl rieschl commented Oct 27, 2020

  • apply current doctrine coding standard v8
  • use self instead of $this in PhpUnit assertions

@rieschl
cs: apply doctrine coding standard
e6fbf26 
qa: use self instead of $this in PhpUnit assertions

Signed-off-by: Thomas Rieschl <thomas@trinet.at>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.333% when pulling e6fbf26 on rieschl:doctrine-coding-standard into e407b28 on doctrine:3.0.x.

@TomHAnderson TomHAnderson self-requested a review October 30, 2020 01:14
@TomHAnderson TomHAnderson merged commit 7d1bad9 into doctrine:3.0.x Oct 30, 2020
@rieschl rieschl deleted the doctrine-coding-standard branch April 23, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomHAnderson TomHAnderson TomHAnderson approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rieschl @coveralls @TomHAnderson @greg0ire