Added registry service

[Spea]

This PR adds a new service doctrine

[Ocramius]

@Spea I'm not sure about what this is for...

[Spea]

I recently created a module for the JMS serializer library. There I have the possibility to use some specific metadata driver for doctrine (see here). As you can see I need an object of type ManagerRegistry for this driver.

Of course I could create this service in the module itself, but I think it makes more sense to implemente it in the ORM module directly.

[Ocramius]

@Spea the idea is nice, but shouldn't this:

1. go to DoctrineModule?
2. have adaptation (where needed) for ORM and ODM modules? (hard part: how do you get the ORM and the ODM modules both working with one factory?)

I think only the factory fits the ORM module.

Can you also add test coverage for these classes please?

[Ocramius]

should probably be doctrine.registry

[Ocramius]

Also, if there is no config to be passed to the RegistryFactory, this can be a string:

'doctrine' => 'DoctrineORMModule\Service\RegistryFactory',

[Spea]

I will create a new PR for the registry class in the DoctrineModule then. I also add some tests for the factory.

[Ocramius]

@Spea thank you.

Please think carefully about how to handle the registry, since ORM and ODM have different keys, and we ideally would want to have a single registry (or at least a registry that knows of any defined EMs/DMs)

[Spea]

I'm not sure about the naming. In the symfony2 bundles the registry services are called doctrine for ORM and doctrine_mongodb for MongoDB. Here I could use doctrine.registry.(orm|odm), if this is ok.

[Spea]

The registry class is always somehow specific when it comes to alias namespaces. I can put the basic parts into the DoctrineModule, but in the end the ORM/ODM module must extend this registry class and implement the getAliasNamespace method.

[Ocramius]

@Spea I'd use a single registry. After all, anything depending on DoctrineModule only should not make ANY assumptions about the implementation of the ObjectManager.

Here's how it could work:

return new ManagerRegistry(array(
    'doctrine.entitymanager',
    'doctrine.documentmanager',
    'doctrine.contentmanager', //example for PHPCR
    'doctrine.graphmanager', // example for OrientDB ODM
));

The problem is indeed the getConfiguration part. Can we inject that too?

return new ManagerRegistry(array(
    'doctrine.entitymanager' => 'doctrine.configuration',
    'doctrine.documentmanager' =>  'doctrine.configuration',
    'doctrine.contentmanager' => 'doctrine.configuration', //example for PHPCR
    'doctrine.graphmanager' => 'doctrine.configuration', // example for OrientDB ODM
));

Good that this came out now, since I also notice all these collisions.

@superdweebie any ideas?

[Spea]

The problem with a single registry also is, that it would be impossible to pass a default connection to the registry (which one should be used).

[Ocramius]

@Spea that is up to the user configuring it I suppose. We can add defaults in the ODM and ORM modules. Last module wins :)

[Ocramius]

I'm closing this after having discussed it a bit with internals. All this registry stuff is basically convoluted, and is here because we still have no clear DI policy in core. There's some movement in data-fixtures, but so far, this is way too hacky, and I prefer not to have this in here.

[eddiejaoude]

Almost 1 year on, is there another solution for this? I have the same issue as @Spea, I wish to use DoctrineTypeDriver with JMS serialiser library, but unable to get the ManagerRegistry

[superdweebie]

@eddiejaoude while it isn't in doctrine-module itself, for the reasons cited above, there is nothing stopping you writing your own factory to return a ManagerRegistry. Use the code in the diff. It should get you most of the way.

[eddiejaoude]

I just wanted to check that nothing official has been done. Yes, I will use the diff as an example. Thanks.

[eddiejaoude]

ZF2 Module on packagist to get ManagerRegistry if anyone else needs it https://packagist.org/packages/eddiejaoude/zf2-doctrine2-manager-registry-service