Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctrine\Migrations require dialog helper #399

Closed
wants to merge 1 commit into from
Closed

Doctrine\Migrations require dialog helper #399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/DoctrineORMModule/Module.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
use Doctrine\DBAL\Tools\Console\Helper\ConnectionHelper;
use Doctrine\ORM\Tools\Console\Helper\EntityManagerHelper;
use Zend\Stdlib\ArrayUtils;
use Symfony\Component\Console\Helper\DialogHelper;

/**
* Base module for Doctrine ORM.
Expand Down Expand Up @@ -142,5 +143,8 @@ public function initializeConsole(EventInterface $event)
$helperSet->set(new QuestionHelper(), 'question');
$helperSet->set(new ConnectionHelper($entityManager->getConnection()), 'db');
$helperSet->set(new EntityManagerHelper($entityManager), 'em');
if (class_exists('Doctrine\\DBAL\\Migrations\\Version')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the check build like this? Can you add a comment?

$helperSet->set(new DialogHelper(), 'dialog');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be done in whatever code adds the migrations stuff, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know.. For me this is a good idea.. But I can move this dependency how required
https://github.com/doctrine/DoctrineORMModule/blob/master/composer.json#L49

:) Now is require dev.. For me it's a good stuff

}
}
}