Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctrine\Migrations require dialog helper #399

Closed
wants to merge 1 commit into from
Closed

Doctrine\Migrations require dialog helper #399

wants to merge 1 commit into from

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Apr 22, 2015

Reference #398-issuecomment-95072327

Problem

In this moment we don't manage a dialog helper for doctrine\migrations component.
This Helper is deprecated but doctrine/migrations use it now.

ping @lastzero for feedback :)

@gianarb gianarb added the Bug Something isn't working label Apr 22, 2015
@gianarb gianarb added this to the 1.0.0 milestone Apr 22, 2015
@@ -142,5 +143,8 @@ public function initializeConsole(EventInterface $event)
$helperSet->set(new QuestionHelper(), 'question');
$helperSet->set(new ConnectionHelper($entityManager->getConnection()), 'db');
$helperSet->set(new EntityManagerHelper($entityManager), 'em');
if (class_exists('Doctrine\\DBAL\\Migrations\\Version')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the check build like this? Can you add a comment?

@gianarb
Copy link
Contributor Author

gianarb commented Apr 28, 2015

Reference #401

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants