DBALConnectionFactory opens db connection, even if its not necessary #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
suggested changes
Jan 16, 2017
| $platform->registerDoctrineTypeMapping($dbType, $doctrineType); | ||
| } | ||
|
|
||
| foreach ($options->getDoctrineCommentedTypes() as $type) { |
There was a problem hiding this comment.
This is a hidden addition that isn't tested
There was a problem hiding this comment.
That was there all along, i only added the if.
| @@ -60,13 +60,16 @@ public function __invoke(ContainerInterface $container, $requestedName, array $o | |||
| $eventManager = $container->get($options->getEventManager()); | |||
|
|
|||
| $connection = DriverManager::getConnection($params, $configuration, $eventManager); | |||
| $platform = $connection->getDatabasePlatform(); | |||
| foreach ($options->getDoctrineTypeMappings() as $dbType => $doctrineType) { | |||
| $platform->registerDoctrineTypeMapping($dbType, $doctrineType); | |||
There was a problem hiding this comment.
A simpler fix is to simply this change this line to $connection->getDatabasePlatform()->registerDoctrineTypeMapping($dbType, $doctrineType);
|
LGTM 👍 |
Ocramius
approved these changes
Jan 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys,
We sometimes got the issue that our app can't connect to our database.
Right now we just get a "ServiceNotCreatedException", because the DBALConnectionFactory opens a db connection while creating the connection services.
This fix only opens a db connection, if needed.
That way we can catch the ConnectionException in our controller/business logic and return a proper response.