Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test minimal version #197

Merged
merged 1 commit into from
May 5, 2015
Merged

test minimal version #197

merged 1 commit into from
May 5, 2015

Conversation

dbu
Copy link
Member

@dbu dbu commented May 2, 2015

No description provided.

@dbu
Copy link
Member Author

dbu commented May 2, 2015

need to wait on doctrine/phpcr-odm#634

env: SYMFONY_VERSION=2.6.*
env: SYMFONY_VERSION=2.5.* PACKAGE_VERSION=high
- php: 5.5
env: SYMFONY_VERSION=2.7.* PACKAGE_VERSION=high
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the remaining issue is deprecation warnings because i also added symfony 2.7 . will have a look at them.

@dbu
Copy link
Member Author

dbu commented May 3, 2015

@wouterj is there a way we can get rid of these deprecation warnings? but i don't really see how we can change the code and not break symfony 2.3 support. or is it the code coverage that somehow makes the build a failure?

@wouterj
Copy link
Contributor

wouterj commented May 3, 2015

@dbu if you remove 2.7 tests from this PR, I'll create another one with the deprecation fixes. These deprecation notices can be fixed without breaking 2.3 support.

@dbu
Copy link
Member Author

dbu commented May 3, 2015 via email

- php: 5.5
env: SYMFONY_VERSION=2.6.*
env: SYMFONY_VERSION=2.5.* PACKAGE_VERSION=high

before_install:
- composer self-update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line should be composer self-update || true. As 5.3.3 doesn't have SSL on Travis, Composer can't run self-update.

@dbu
Copy link
Member Author

dbu commented May 4, 2015

@wouterj hm so composer self-update actually works, but fetching packages.json in composer update does not work: https://travis-ci.org/doctrine/DoctrinePHPCRBundle/jobs/61107070

@wouterj
Copy link
Contributor

wouterj commented May 4, 2015

@dbu seems like composer usage is now completely broken on PHP 5.3.3 builds

@wouterj
Copy link
Contributor

wouterj commented May 4, 2015

@dbu it seems like composer usage is now complete broken on Travis for 5.3.3 (I saw that the tests were broken for Symfony too)

@dbu
Copy link
Member Author

dbu commented May 4, 2015

crap. should we just say php 5.3 and hope on good luck for people still on 5.3.3?

@wouterj
Copy link
Contributor

wouterj commented May 4, 2015

@dbu the tests on 5.3.3 should be fixed now. see http://seld.be/notes/composer-hosting-improvements :

While the whole change happened without packagist downtime, there were a few minor issues early last week with the composer homepage. Today I had to re-enable http (i.e. no-TLS) access to packagist.org as people are still relying on accessing it without the openssl extension. This is not great but the travis 5.3.3 builds are missing openssl so it's not realistic to require it, hopefully in a year or two when 5.3 is a thing of the past we can go full-TLS.

dbu added a commit that referenced this pull request May 5, 2015
@dbu dbu merged commit 7a49ef8 into master May 5, 2015
@dbu dbu deleted the test-minimal-version branch May 5, 2015 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants