remove .class parameters and start 2.0 preparation

[dbu]

No description provided.

[ElectricMaxxx]

Nice circulary dependency, shall i add 1.1|2.0 on testing?

[ElectricMaxxx]

can you go on @2.1 for symfony/testing here, please.

[ElectricMaxxx]

two times 2.8.* ?

[dbu]

erm. whatever i did, thanks for spotting, deleting this

[ElectricMaxxx]

I think we can not remove those as Symfony-Doctrine-Bridge still uses those .class parameters. to create the mapping driver stuff

[dbu]

i do not see DoctrinePhpcrMappingsPass or the abstract class use any .class parameters. then again, i did not see where the DoctrinePhpcrMappingsPass is even registered at all. did you see where that happens?

[ElectricMaxxx]

It was quite hard to find them. They live in AbstractDoctrineExtension of symfony/doctrine-bridge. I greped for anotation or .class the complete parameter id is concatenated in php except .class

[ElectricMaxxx]

https://github.com/symfony/doctrine-bridge/blob/master/DependencyInjection/AbstractDoctrineExtension.php#L200 here is an example

[ElectricMaxxx]

 +
 +        <parameter key="doctrine_phpcr.odm.metadata.annotation.class">Doctrine\ODM\PHPCR\Mapping\Driver\AnnotationDriver</parameter>
 +        <parameter key="doctrine_phpcr.odm.metadata.driver_chain.class">Doctrine\Common\Persistence\Mapping\Driver\MappingDriverChain</parameter>
 +        <parameter key="doctrine_phpcr.odm.cache.array.class">Doctrine\Common\Cache\ArrayCache</parameter>

let the tests run again.

[dbu]

ah, got it. added the other cache related parameters back as well, as they look used in the extension. this is one of the uglier pieces of symfony code ...

[ElectricMaxxx]

I will add a note.

[ElectricMaxxx]

I am behind your branch with mine and recognized some missing class parameters which are used in AbstractDcotrineExtension of doctrine bridge. I got exceptions like:

[Symfony\Component\DependencyInjection\Exception\ParameterNotFoundException]  
  The service "doctrine_phpcr.odm.default_annotation_metadata_driver" has a d   
  ependency on a non-existent parameter "doctrine_phpcr.odm.metadata.annotati   
  on.class".             

I added 3 removed class parameters, you can find them on my diff against yours.

[ElectricMaxxx]

Ahh, cool i got the same: https://travis-ci.org/doctrine/DoctrinePHPCRBundle/jobs/297847476
now it yours :-)
I have no clue where those classes are used.

[dbu]

i think new versions of doctrine jumped to support only php 7.1 and better. i am actually considering the same for phpcr-odm to stay in sync with the rest of the doctrine universe. if we do that, we can drop php 5 here as well. wdyt?

[ElectricMaxxx]

👍 for dropping php 5
using symfony 4.0 + will lead us to use php 7.1 + later

[dbu]

yay, looks green now!

[ElectricMaxxx]

yes