Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoctrineBridge] clean up .class parameters #24835

Closed
ElectricMaxxx opened this issue Nov 6, 2017 · 5 comments
Closed

[DoctrineBridge] clean up .class parameters #24835

ElectricMaxxx opened this issue Nov 6, 2017 · 5 comments

Comments

@ElectricMaxxx
Copy link
Contributor

Q A
Bug report? no
Feature request? yes
BC Break report? yes
RFC? yes
Symfony version 4.0.0

In ExtensionClass of DoctrineBridge several services are defined by using a parameter with *.class This should be replaced by a kind of a configuration or an alias.
One the one hand we decided to abandon those class parameters and on the other hand they are extremely hidden doing it that way.

@fabpot
Copy link
Member

fabpot commented Feb 22, 2018

@ElectricMaxxx Would you like to work on this one? Is it worth it?

@ElectricMaxxx
Copy link
Contributor Author

I can try to do so next days. can be funny as the parameters mostly defined in extension class.

@dbu
Copy link
Contributor

dbu commented Feb 23, 2018

what would the solution be? the doctrine bundles prepending configuration for the bridge? we have to avoid manual steps where the user must configure the bridge in a specific way.

@ElectricMaxxx
Copy link
Contributor Author

Sorry for the delay, i am currently on it. If somebody has some insight for me, that would be nice looking into the extension class is really hard as used to for every extension class in doctrine namespace.

@fabpot
Copy link
Member

fabpot commented Aug 6, 2019

Let's close as nobody really took the time to do it.

@fabpot fabpot closed this as completed Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants