added cache-invalidator-listener service #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ($document instanceof Image) { | ||
| // TODO: this does not work, what do we need to pass to manager->remove? | ||
| // TODO: can we invalidate all caches? otherwise inject filter name(s)? by config | ||
| $this->manager->remove($document->getId(), 'image_upload_thumbnail'); |
There was a problem hiding this comment.
On 0.9.x you need to resolve the name first, see liip/LiipImagineBundle#135 (comment)
| $path = $this->manager->resolve($this->container->get('request'), $document->getId(), 'image_upload_thumbnail')->getTargetUrl(); | ||
| // TODO: this might not be needed https://github.com/liip/LiipImagineBundle/issues/162 | ||
| if (false !== strpos($path, $filter)) { | ||
| $path = substr($path, strpos($path, $filter) + strlen($filter)); |
There was a problem hiding this comment.
if i get a reply on that issue today, i will clean this up if possible.
dbu
added a commit
that referenced
this pull request
Mar 14, 2013
…ener added cache-invalidator-listener service
|
also cleaned up the configuration. you now need to explicitly enable imagine to have this block. the full config options for imagine are now guess i have to update the doc as well... /cc @rryter @elHornair |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we started with a listener service to go with the image document. whenever the image changes, the imagine cache should be invalidated.